fix minor code smells
This commit is contained in:
@ -38,10 +38,11 @@ def sort_models(models: List["Model"], orders_by: Dict) -> List["Model"]:
|
||||
]
|
||||
sort_criteria = sort_criteria[::-1]
|
||||
for criteria in sort_criteria:
|
||||
if criteria[1] == "desc":
|
||||
models.sort(key=lambda x: getattr(x, criteria[0]), reverse=True)
|
||||
key, value = criteria
|
||||
if value == "desc":
|
||||
models.sort(key=lambda x: getattr(x, key), reverse=True)
|
||||
else:
|
||||
models.sort(key=lambda x: getattr(x, criteria[0]))
|
||||
models.sort(key=lambda x: getattr(x, key))
|
||||
return models
|
||||
|
||||
|
||||
|
||||
@ -51,8 +51,7 @@ class QuerySet:
|
||||
) -> "QuerySet":
|
||||
if issubclass(owner, ormar.Model):
|
||||
return self.__class__(model_cls=owner)
|
||||
else: # pragma nocover
|
||||
return self.__class__()
|
||||
return self.__class__() # pragma: no cover
|
||||
|
||||
@property
|
||||
def model_meta(self) -> "ModelMeta":
|
||||
|
||||
Reference in New Issue
Block a user