Prodream/ormar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

excludee null fields in _construct_relations (#870)

Browse Source 
* excludee null fields in _construct_relations

* add missing test to check empty relation in construct

Co-authored-by: collerek <collerek@gmail.com>
This commit is contained in:
Abdeldjalil-H
2022-10-11 15:55:08 +01:00
committed by GitHub
parent 3661967a27
commit 2c1768bb61
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ormar/models/newbasemodel.py
View File

@ -859,6 +859,7 @@ class NewBaseModel(pydantic.BaseModel, ModelTableProxy, metaclass=ModelMetaclass
relation_value = [ relation_value = [
relation_field.expand_relationship(x, model, to_register=False) relation_field.expand_relationship(x, model, to_register=False)
for x in value_to_set for x in value_to_set
if x is not None
] ]
for child in relation_value: for child in relation_value:

10
tests/test_model_definition/test_model_construct.py
View File

@ -60,6 +60,16 @@ def create_test_database():
metadata.drop_all(engine) metadata.drop_all(engine)
@pytest.mark.asyncio
async def test_construct_with_empty_relation():
async with database:
async with database.transaction(force_rollback=True):
hq = await HQ.objects.create(name="Main")
comp = Company(name="Banzai", hq=None, founded=1988)
comp2 = Company.construct(**dict(name="Banzai", hq=None, founded=1988))
assert comp.dict() == comp2.dict()
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_init_and_construct_has_same_effect(): async def test_init_and_construct_has_same_effect():
async with database: async with database: