Fix add_field_serializer_for_reverse_relations clearing validators (#1302)

* Fix add_field_serializer_for_reverse_relations clearing validators

* add test to check that validators are not removed

* compatibility with old python

* fix test default values

* fix coverage and cleanup

---------

Co-authored-by: collerek <collerek@gmail.com>
This commit is contained in:
Camillo
2024-06-10 01:43:56 -07:00
committed by GitHub
parent ef02f9e553
commit 318fe54832
3 changed files with 82 additions and 7 deletions

View File

@ -97,7 +97,25 @@ async def test_related_with_defaults(sample_data):
"year": 2021,
}
],
"country": {"authors": [{"id": 1}], "id": 1},
"country": {
"authors": [
{
"books": [
{
"author": {"id": 1},
"id": 1,
"title": "Bug caused by " "default value",
"year": 2021,
}
],
"country": {"id": 1},
"id": 1,
"name": "bug",
"rating": 5,
}
],
"id": 1,
},
"id": 1,
"name": "bug",
"rating": 5,

View File

@ -0,0 +1,48 @@
from typing import List, Optional, Union
import ormar
import pytest_asyncio
from pydantic import field_validator
from tests.lifespan import init_tests
from tests.settings import create_config
base_ormar_config = create_config()
class Author(ormar.Model):
ormar_config = base_ormar_config.copy()
id: int = ormar.Integer(primary_key=True)
name: str = ormar.String(max_length=80)
@field_validator("name", mode="before")
@classmethod
def validate_name(cls, v: Union[str, List[str]]) -> str:
if isinstance(v, list):
v = " ".join(v)
return v
class Post(ormar.Model):
ormar_config = base_ormar_config.copy()
id: int = ormar.Integer(primary_key=True)
title: str = ormar.String(max_length=200)
author: Optional[Author] = ormar.ForeignKey(Author)
create_test_database = init_tests(base_ormar_config)
@pytest_asyncio.fixture(scope="function", autouse=True)
async def cleanup():
yield
async with base_ormar_config.database:
await Post.objects.delete(each=True)
await Author.objects.delete(each=True)
def test_validator():
author = Author(name=["Test", "Author"])
assert author.name == "Test Author"