WIP - Pydantic v2 support (#1238)

* WIP

* WIP - make test_model_definition tests pass

* WIP - make test_model_methods pass

* WIP - make whole test suit at least run - failing 49/443 tests

* WIP fix part of the getting pydantic tests as types of fields are now kept in core schema and not on fieldsinfo

* WIP fix validation in update by creating individual fields validators, failing 36/443

* WIP fix __pydantic_extra__ in intializing model, fix test related to pydantic config checks, failing 32/442

* WIP - fix enum schema in model_json_schema, failing 31/442

* WIP - fix copying through model, fix setting pydantic fields on through, fix default config and inheriting from it, failing 26/442

* WIP fix tests checking pydantic schema, fix excluding parent fields, failing 21/442

* WIP some missed files

* WIP - fix validators inheritance and fix validators in generated pydantic, failing 17/442

* WIP - fix through models setting - only on reverse side of relation, but always on reverse side, failing 15/442

* WIP - fix through models setting - only on reverse side of relation, but always on reverse side, failing 15/442

* WIP - working on proper populating __dict__ for relations for new schema dumping, some work on openapi docs, failing 13/442

* WIP - remove property fields as pydantic has now computed_field on its own, failing 9/442

* WIP - fixes in docs, failing 8/442

* WIP - fix tests for largebinary schema, wrapped bytes fields fail in pydantic, will be fixed in pydantic-core, remaining is circural schema for related models, failing 6/442

* WIP - fix to pk only models in schemas

* Getting test suites to pass (#1249)

* wip, fixing tests

* iteration, fixing some more tests

* iteration, fixing some more tests

* adhere to comments

* adhere to comments

* remove unnecessary dict call, re-add getattribute for testing

* todo for reverse relationship

* adhere to comments, remove prints

* solve circular refs

* all tests pass 🎉

* remove 3.7 from tests

* add lint and type check jobs

* reforat with ruff, fix jobs

* rename jobs

* fix imports

* fix evaluate in py3.8

* partially fix coverage

* fix coverage, add more tests

* fix test ids

* fix test ids

* fix lint, fix docs, make docs fully working scripts, add test docs job

* fix pyproject

* pin py ver in test docs

* change dir in test docs

* fix pydantic warning hack

* rm poetry call in test_docs

* switch to pathlib in test docs

* remove coverage req test docs

* fix type check tests, fix part of types

* fix/skip next part of types

* fix next part of types

* fix next part of types

* fix coverage

* fix coverage

* fix type (bit dirty 🤷)

* fix some code smells

* change pre-commit

* tweak workflows

* remove no root from tests

* switch to full python path by passing sys.executable

* some small refactor in new base model, one sample test, change makefile

* small refactors to reduce complexity of methods

* temp add tests for prs against pydantic_v2

* remove all references to __fields__

* remove all references to construct, deprecate the method and update model_construct to be in line with pydantic

* deprecate dict and add model_dump, todo switch to model_dict in calls

* fix tests

* change to union

* change to union

* change to model_dump and model_dump_json from dict and json deprecated methods, deprecate them in ormar too

* finish switching dict() -> model_dump()

* finish switching json() -> model_dump_json()

* remove fully pydantic_only

* switch to extra for payment card, change missed json calls

* fix coverage - no more warnings internal

* fix coverage - no more warnings internal - part 2

* split model_construct into own and pydantic parts

* split determine pydantic field type

* change to new field validators

* fix benchmarks, add codspeed instead of pytest-benchmark, add action and gh workflow

* restore pytest-benchmark

* remove codspeed

* pin pydantic version, restore codspeed

* change on push to pydantic_v2 to trigger first one

* Use lifespan function instead of event (#1259)

* check return types

* fix imports order, set warnings=False on json that passes the dict, fix unnecessary loop in one of the test

* remove references to model's meta as it's now ormar config, rename related methods too

* filter out pydantic serializer warnings

* remove choices leftovers

* remove leftovers after property_fields, keep only enough to exclude them in initialization

* add migration guide

* fix meta references

* downgrade databases for now

* Change line numbers in documentation (#1265)

* proofread and fix the docs, part 1

* proofread and fix the docs for models

* proofread and fix the docs for fields

* proofread and fix the docs for relations

* proofread and fix rest of the docs, add release notes for 0.20

* create tables in new docs src

* cleanup old deps, uncomment docs publish on tag

* fix import reorder

---------

Co-authored-by: TouwaStar <30479449+TouwaStar@users.noreply.github.com>
Co-authored-by: Goran Mekić <meka@tilda.center>
This commit is contained in:
collerek
2024-03-23 19:28:28 +01:00
committed by GitHub
parent 3a206dd8dc
commit 500625f0ec
294 changed files with 8132 additions and 9311 deletions

View File

@ -1,33 +1,23 @@
from typing import Any, Sequence, cast
import databases
import pytest
import sqlalchemy
from pydantic.typing import ForwardRef
from typing import Any, ForwardRef
import ormar
from tests.settings import DATABASE_URL
import pytest
database = databases.Database(DATABASE_URL, force_rollback=True)
metadata = sqlalchemy.MetaData()
from tests.lifespan import init_tests
from tests.settings import create_config
class BaseMeta(ormar.ModelMeta):
database = database
metadata = metadata
base_ormar_config = create_config(force_rollback=True)
class Category(ormar.Model):
class Meta(BaseMeta):
tablename = "categories"
ormar_config = base_ormar_config.copy(tablename="categories")
id = ormar.Integer(primary_key=True)
name = ormar.String(max_length=40)
class PostCategory(ormar.Model):
class Meta(BaseMeta):
tablename = "posts_x_categories"
ormar_config = base_ormar_config.copy(tablename="posts_x_categories")
id: int = ormar.Integer(primary_key=True)
sort_order: int = ormar.Integer(nullable=True)
@ -35,16 +25,14 @@ class PostCategory(ormar.Model):
class Blog(ormar.Model):
class Meta(BaseMeta):
pass
ormar_config = base_ormar_config.copy()
id: int = ormar.Integer(primary_key=True)
title: str = ormar.String(max_length=200)
class Post(ormar.Model):
class Meta(BaseMeta):
pass
ormar_config = base_ormar_config.copy()
id: int = ormar.Integer(primary_key=True)
title: str = ormar.String(max_length=200)
@ -52,26 +40,18 @@ class Post(ormar.Model):
blog = ormar.ForeignKey(Blog)
@pytest.fixture(autouse=True, scope="module")
def create_test_database():
engine = sqlalchemy.create_engine(DATABASE_URL)
metadata.drop_all(engine)
metadata.create_all(engine)
yield
metadata.drop_all(engine)
create_test_database = init_tests(base_ormar_config)
class PostCategory2(ormar.Model):
class Meta(BaseMeta):
tablename = "posts_x_categories2"
ormar_config = base_ormar_config.copy(tablename="posts_x_categories2")
id: int = ormar.Integer(primary_key=True)
sort_order: int = ormar.Integer(nullable=True)
class Post2(ormar.Model):
class Meta(BaseMeta):
pass
ormar_config = base_ormar_config.copy()
id: int = ormar.Integer(primary_key=True)
title: str = ormar.String(max_length=200)
@ -80,16 +60,16 @@ class Post2(ormar.Model):
@pytest.mark.asyncio
async def test_forward_ref_is_updated():
async with database:
assert Post2.Meta.requires_ref_update
async with base_ormar_config.database:
assert Post2.ormar_config.requires_ref_update
Post2.update_forward_refs()
assert Post2.Meta.model_fields["postcategory2"].to == PostCategory2
assert Post2.ormar_config.model_fields["postcategory2"].to == PostCategory2
@pytest.mark.asyncio
async def test_setting_fields_on_through_model():
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
category = await Category(name="Test category").save()
await post.categories.add(category)
@ -100,7 +80,7 @@ async def test_setting_fields_on_through_model():
@pytest.mark.asyncio
async def test_setting_additional_fields_on_through_model_in_add():
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
category = await Category(name="Test category").save()
await post.categories.add(category, sort_order=1)
@ -110,7 +90,7 @@ async def test_setting_additional_fields_on_through_model_in_add():
@pytest.mark.asyncio
async def test_setting_additional_fields_on_through_model_in_create():
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category2", postcategory={"sort_order": 2}
@ -121,7 +101,7 @@ async def test_setting_additional_fields_on_through_model_in_create():
@pytest.mark.asyncio
async def test_getting_additional_fields_from_queryset() -> Any:
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category1", postcategory={"sort_order": 1}
@ -143,7 +123,7 @@ async def test_getting_additional_fields_from_queryset() -> Any:
@pytest.mark.asyncio
async def test_only_one_side_has_through() -> Any:
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category1", postcategory={"sort_order": 1}
@ -168,7 +148,7 @@ async def test_only_one_side_has_through() -> Any:
@pytest.mark.asyncio
async def test_filtering_by_through_model() -> Any:
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category1",
@ -195,7 +175,7 @@ async def test_filtering_by_through_model() -> Any:
@pytest.mark.asyncio
async def test_deep_filtering_by_through_model() -> Any:
async with database:
async with base_ormar_config.database:
blog = await Blog(title="My Blog").save()
post = await Post(title="Test post", blog=blog).save()
@ -226,7 +206,7 @@ async def test_deep_filtering_by_through_model() -> Any:
@pytest.mark.asyncio
async def test_ordering_by_through_model() -> Any:
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category1",
@ -261,7 +241,7 @@ async def test_ordering_by_through_model() -> Any:
@pytest.mark.asyncio
async def test_update_through_models_from_queryset_on_through() -> Any:
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category1",
@ -290,7 +270,7 @@ async def test_update_through_models_from_queryset_on_through() -> Any:
@pytest.mark.asyncio
async def test_update_through_model_after_load() -> Any:
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category1",
@ -309,7 +289,7 @@ async def test_update_through_model_after_load() -> Any:
@pytest.mark.asyncio
async def test_update_through_from_related() -> Any:
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category1",
@ -338,7 +318,7 @@ async def test_update_through_from_related() -> Any:
@pytest.mark.asyncio
async def test_excluding_fields_on_through_model() -> Any:
async with database:
async with base_ormar_config.database:
post = await Post(title="Test post").save()
await post.categories.create(
name="Test category1",