From 8b951a48beff648af13cb966bea12507023404a0 Mon Sep 17 00:00:00 2001 From: collerek Date: Tue, 20 Apr 2021 11:59:36 +0200 Subject: [PATCH] remove emailstr to vavoid additional deps --- tests/test_model_definition/test_pydantic_fields.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tests/test_model_definition/test_pydantic_fields.py b/tests/test_model_definition/test_pydantic_fields.py index d41669a..b4be0ae 100644 --- a/tests/test_model_definition/test_pydantic_fields.py +++ b/tests/test_model_definition/test_pydantic_fields.py @@ -3,7 +3,7 @@ from typing import Optional import databases import pytest import sqlalchemy -from pydantic import EmailStr, HttpUrl, ValidationError +from pydantic import HttpUrl import ormar from tests.settings import DATABASE_URL @@ -23,15 +23,12 @@ class Test(ormar.Model): def __init__(self, **kwargs): # you need to pop non - db fields as ormar will complain that it's unknown field - email = kwargs.pop("email", self.__fields__["email"].get_default()) url = kwargs.pop("url", self.__fields__["url"].get_default()) super().__init__(**kwargs) - self.email = email self.url = url id: int = ormar.Integer(primary_key=True) name: str = ormar.String(max_length=200) - email: Optional[EmailStr] # field optional - default to None url: HttpUrl = "www.example.com" # field with default @@ -47,19 +44,17 @@ def create_test_database(): @pytest.mark.asyncio async def test_working_with_pydantic_fields(): async with database: - test = Test(name="Test", email="aka@go2.com") + test = Test(name="Test") assert test.name == "Test" - assert test.email == "aka@go2.com" assert test.url == "www.example.com" - test.email = "sdta@ada.pt" - assert test.email == "sdta@ada.pt" + test.url = "www.sdta.ada.pt" + assert test.url == "www.sdta.ada.pt" await test.save() test_check = await Test.objects.get() assert test_check.name == "Test" - assert test_check.email is None assert test_check.url == "www.example.com" # TODO add validate assignment to pydantic config