fix minor code smells

ormar/fields/foreign_key.py

@@ -72,8 +72,6 @@ class UniqueColumns(UniqueConstraint):
     Used to avoid importing anything from sqlalchemy by user.
     """
 
-    pass
-
 
 @dataclass
 class ForeignKeyConstraint:

ormar/fields/model_fields.py

@@ -112,7 +112,6 @@ class ModelFieldFactory:
         :param kwargs: all params passed during construction
         :type kwargs: Any
         """
-        pass
 
 
 class String(ModelFieldFactory, str):

ormar/models/helpers/models.py

@@ -79,5 +79,4 @@ def validate_related_names_in_relations(
                     f"default/empty name: '{new_model.get_name() + 's'}'"
                     f"\nTip: provide different related_name for FK and/or M2M fields"
                 )
-            else:
             previous_related_names.append(field.related_name)

tests/test_inheritance_concrete.py

@@ -4,7 +4,6 @@ from typing import List, Optional
 
 import databases
 import pytest
-import sqlalchemy
 import sqlalchemy as sa
 from sqlalchemy import create_engine
 
@@ -196,8 +195,7 @@ def test_field_redefining_in_concrete_models():
     assert changed_field.alias == "creation_date"
     assert any(x.name == "creation_date" for x in RedefinedField.Meta.table.columns)
     assert isinstance(
-        RedefinedField.Meta.table.columns["creation_date"].type,
+        RedefinedField.Meta.table.columns["creation_date"].type, sa.sql.sqltypes.String,
-        sqlalchemy.sql.sqltypes.String,
     )
 
 

tests/test_inheritance_mixins.py

@@ -4,12 +4,10 @@ from typing import Optional
 
 import databases
 import pytest
-import sqlalchemy
 import sqlalchemy as sa
 from sqlalchemy import create_engine
 
 import ormar
-from ormar import ModelDefinitionError
 from tests.settings import DATABASE_URL
 
 metadata = sa.MetaData()
@@ -94,7 +92,7 @@ def test_field_redefining_in_second_raises_error():
     assert any(x.name == "creation_date" for x in RedefinedField2.Meta.table.columns)
     assert isinstance(
         RedefinedField2.Meta.table.columns["creation_date"].type,
-        sqlalchemy.sql.sqltypes.String,
+        sa.sql.sqltypes.String,
     )