finish mypy checks add reqs and linting

This commit is contained in:
collerek
2020-09-29 17:06:41 +02:00
parent 3caa87057e
commit d9aa269f7a
16 changed files with 122 additions and 81 deletions

View File

@ -1,7 +1,7 @@
import string
import uuid
from random import choices
from typing import List, Dict
from typing import Dict, List
import sqlalchemy
from sqlalchemy import text

View File

@ -1,4 +1,4 @@
from typing import Any, List, TYPE_CHECKING, Tuple, Union
from typing import Any, List, Optional, TYPE_CHECKING, Union
import ormar
@ -14,14 +14,25 @@ class QuerysetProxy:
def __init__(self, relation: "Relation") -> None:
self.relation: Relation = relation
self.queryset: "QuerySet"
self._queryset: Optional["QuerySet"] = None
def _assign_child_to_parent(self, child: "Model") -> None:
owner = self.relation._owner
rel_name = owner.resolve_relation_name(owner, child)
setattr(owner, rel_name, child)
@property
def queryset(self) -> "QuerySet":
if not self._queryset:
raise AttributeError
return self._queryset
def _register_related(self, child: Union["Model", List["Model"]]) -> None:
@queryset.setter
def queryset(self, value: "QuerySet") -> None:
self._queryset = value
def _assign_child_to_parent(self, child: Optional["Model"]) -> None:
if child:
owner = self.relation._owner
rel_name = owner.resolve_relation_name(owner, child)
setattr(owner, rel_name, child)
def _register_related(self, child: Union["Model", List[Optional["Model"]]]) -> None:
if isinstance(child, list):
for subchild in child:
self._assign_child_to_parent(subchild)
@ -40,13 +51,13 @@ class QuerysetProxy:
owner_column = self.relation._owner.get_name()
child_column = child.get_name()
kwargs = {owner_column: self.relation._owner, child_column: child}
link_instance = await queryset.filter(**kwargs).get()
link_instance = await queryset.filter(**kwargs).get() # type: ignore
await link_instance.delete()
def filter(self, **kwargs: Any) -> "QuerySet": # noqa: A003
return self.queryset.filter(**kwargs)
def select_related(self, related: Union[List, Tuple, str]) -> "QuerySet":
def select_related(self, related: Union[List, str]) -> "QuerySet":
return self.queryset.select_related(related)
async def exists(self) -> bool:
@ -59,7 +70,7 @@ class QuerysetProxy:
queryset = ormar.QuerySet(model_cls=self.relation.through)
owner_column = self.relation._owner.get_name()
kwargs = {owner_column: self.relation._owner}
return await queryset.delete(**kwargs)
return await queryset.delete(**kwargs) # type: ignore
def limit(self, limit_count: int) -> "QuerySet":
return self.queryset.limit(limit_count)
@ -77,7 +88,7 @@ class QuerysetProxy:
self._register_related(get)
return get
async def all(self, **kwargs: Any) -> List["Model"]: # noqa: A003
async def all(self, **kwargs: Any) -> List[Optional["Model"]]: # noqa: A003
all_items = await self.queryset.all(**kwargs)
self._register_related(all_items)
return all_items

View File

@ -20,11 +20,11 @@ class RelationType(Enum):
class Relation:
def __init__(
self,
manager: "RelationsManager",
type_: RelationType,
to: Type["Model"],
through: Type["Model"] = None,
self,
manager: "RelationsManager",
type_: RelationType,
to: Type["Model"],
through: Type["Model"] = None,
) -> None:
self.manager = manager
self._owner: "Model" = manager.owner
@ -37,7 +37,9 @@ class Relation:
else None
)
def _find_existing(self, child: "Model") -> Optional[int]:
def _find_existing(
self, child: Union["NewBaseModel", Type["NewBaseModel"]]
) -> Optional[int]:
if not isinstance(self.related_models, RelationProxy): # pragma nocover
raise ValueError("Cannot find existing models in parent relation type")
for ind, relation_child in enumerate(self.related_models[:]):

View File

@ -1,4 +1,4 @@
from typing import List, Optional, TYPE_CHECKING, Type, Union, Dict
from typing import Dict, List, Optional, TYPE_CHECKING, Type, Union
from weakref import proxy
from ormar.fields import BaseField
@ -17,9 +17,9 @@ if TYPE_CHECKING: # pragma no cover
class RelationsManager:
def __init__(
self,
related_fields: List[Type[ForeignKeyField]] = None,
owner: "NewBaseModel" = None,
self,
related_fields: List[Type[ForeignKeyField]] = None,
owner: "NewBaseModel" = None,
) -> None:
self.owner = proxy(owner)
self._related_fields = related_fields or []
@ -73,13 +73,17 @@ class RelationsManager:
if child_relation:
child_relation.add(parent)
def remove(self, name: str, child: Union["NewBaseModel", Type["NewBaseModel"]]) -> None:
def remove(
self, name: str, child: Union["NewBaseModel", Type["NewBaseModel"]]
) -> None:
relation = self._get(name)
if relation:
relation.remove(child)
@staticmethod
def remove_parent(item: Union["NewBaseModel", Type["NewBaseModel"]], name: "Model") -> None:
def remove_parent(
item: Union["NewBaseModel", Type["NewBaseModel"]], name: "Model"
) -> None:
related_model = name
rel_name = item.resolve_relation_name(item, related_model)
if rel_name in item._orm:

View File

@ -1,4 +1,4 @@
from typing import TYPE_CHECKING, Tuple, Type, Optional
from typing import Optional, TYPE_CHECKING, Tuple, Type
from weakref import proxy
import ormar