Prodream/ormar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix minor code smells

Browse Source
This commit is contained in:
collerek
2021-03-09 10:27:20 +01:00
parent 0ea9b0952c
commit fdb6c3089f
2 changed files with 44 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ormar/queryset/actions/order_action.py
View File

@ -57,7 +57,6 @@ class OrderAction(QueryAction):
prefix = f"{self.table_prefix}_" if self.table_prefix else "" prefix = f"{self.table_prefix}_" if self.table_prefix else ""
if self.direction == "": if self.direction == "":
return text(f"min({prefix}{self.table}" f".{self.field_alias})") return text(f"min({prefix}{self.table}" f".{self.field_alias})")
else:
return text(f"max({prefix}{self.table}" f".{self.field_alias}) desc") return text(f"max({prefix}{self.table}" f".{self.field_alias}) desc")
def get_text_clause(self) -> sqlalchemy.sql.expression.TextClause: def get_text_clause(self) -> sqlalchemy.sql.expression.TextClause:

11
tests/test_or_filters.py
View File

@ -236,14 +236,3 @@ async def test_or_filters():
.all() .all()
) )
assert len(books) == 5 assert len(books) == 5
# TODO: Check / modify
# process and and or into filter groups (V)
# check exclude queries working (V)
# check complex prefixes properly resolved (V)
# fix limit -> change to where subquery to extract number of distinct pk values (V)
# finish docstrings (V)
# fix types for FilterAction and FilterGroup (X)
# add docs (V)
# fix querysetproxy (V)