fix minor code smells
This commit is contained in:
@ -57,7 +57,6 @@ class OrderAction(QueryAction):
|
||||
prefix = f"{self.table_prefix}_" if self.table_prefix else ""
|
||||
if self.direction == "":
|
||||
return text(f"min({prefix}{self.table}" f".{self.field_alias})")
|
||||
else:
|
||||
return text(f"max({prefix}{self.table}" f".{self.field_alias}) desc")
|
||||
|
||||
def get_text_clause(self) -> sqlalchemy.sql.expression.TextClause:
|
||||
|
||||
@ -236,14 +236,3 @@ async def test_or_filters():
|
||||
.all()
|
||||
)
|
||||
assert len(books) == 5
|
||||
|
||||
|
||||
# TODO: Check / modify
|
||||
# process and and or into filter groups (V)
|
||||
# check exclude queries working (V)
|
||||
# check complex prefixes properly resolved (V)
|
||||
# fix limit -> change to where subquery to extract number of distinct pk values (V)
|
||||
# finish docstrings (V)
|
||||
# fix types for FilterAction and FilterGroup (X)
|
||||
# add docs (V)
|
||||
# fix querysetproxy (V)
|
||||
|
||||
Reference in New Issue
Block a user